[Linux][Backtracing] Don't try to use process_vm_readv().
#84122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to try to use `process_vm_readv()` if `CAP_SYS_PTRACE` is enabled. This avoided using signal handlers to catch crashes when we try to read through an invalid pointer, but it complicates the code and it turns out not to work on some Linux kernels where the `process_vm_readv()` syscall is unavailable. rdar://159930644
|
@swift-ci Please smoke test |
FranzBusch
approved these changes
Sep 5, 2025
|
Linux failure doesn't look related. |
|
@swift-ci Please smoke test Linux Platform |
mikeash
approved these changes
Sep 5, 2025
owenv
approved these changes
Sep 5, 2025
This was referenced Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to try to use
process_vm_readv()ifCAP_SYS_PTRACEis enabled. This avoided using signal handlers to catch crashes when we try to read through an invalid pointer, but it complicates the code and it turns out not to work on some Linux kernels where theprocess_vm_readv()syscall is unavailable.rdar://159930644